refactor(uri): consolidate PathAndQuery::from_shared and from_static#825
Open
seanmonstar wants to merge 1 commit intomasterfrom
Open
refactor(uri): consolidate PathAndQuery::from_shared and from_static#825seanmonstar wants to merge 1 commit intomasterfrom
seanmonstar wants to merge 1 commit intomasterfrom
Conversation
Previously, the constructors had their logic nearly duplicated, one to fit the const fn context, with minor differences. This change consolidates it back into a single const fn, with the non-const parts separated out, so that the parsing logic does not drift unintentionally.
seanmonstar
force-pushed
the
sean/rsskqlwttklz
branch
from
aff45ab to
b69389a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the constructors had their logic nearly duplicated, one to fit the const fn context, with minor differences. This change consolidates it back into a single const fn, with the non-const parts separated out, so that the parsing logic does not drift unintentionally.